Dan Schult

Results 563 comments of Dan Schult

I think those errors have been fixed in the main branch. Can you rebase or merge the main branch into your branch and push that? That should update the code...

The design seems to be that changes to the `colors` dict [occur between the yield](https://github.com/networkx/networkx/blob/9cc8b422a512e7e7819238d597fd6815ec9c1c8e/networkx/algorithms/coloring/greedy_coloring.py#L381) and the `next` call to the generator. The generator does not have control over that...

I think this points out how interrelated this function is to the calling function. It might make sense to make these strategy functions private. But they have been public for...

I have only quickly looked through it and saw no obvious issues on a first pass (Good job!). I still need to look deeper at the code/interface relative to others...

This example uses `nx.grid_2d_graph` which creates nodes that are 2-tuples of ints (positions in the 2d grid). So interpreting each 2-tuple of ints as a node, this suggests that the...

After our discussion in todays community meeting I looked at this again to refresh my memory. We **are** keeping the old code (`PythonRandomInterface`) and using that whenever a user provides...

Thanks @stefanv -- it would be great if you could review this. We are keeping around the older PythonRandomInterface class for backward compatibility. It is triggered when someone inputs a...

Just a restatement for clarity that: - for the code that uses this functionality, the default random number system is Python Random... So this is independent of any backward bit...

Thanks for these comments/suggestions! PR #7322 implements them. I think the wording is clearer -- but is it clear enough? :)

As I hinted above, my knee-jerk reaction about subclass-ing dict is based solely on my experience with performance issues. That experience may not apply here. For example, maybe performance doesn't...