Dan Schult

Results 450 comments of Dan Schult
trafficstars

The current Johnson method doesn't handle ties. I'm not sure whether it is worth adding it here. If you want to, go for it. But if you'd rather get this...

Rats! I didn't look at the PR closely enough. For each of the new functions you should include an entry in the appropriate `.rst` file in `doc/reference/algorithms/shortest_paths.rst` If the pattern...

Let's switch focus for this issue/PR to #6238

@klezm's suggestions for handling edge attributes shows a nice (and general) way to think about edge attributes on a rooted tree. You can associate each edge with the node on...

I tried to rebase this PR on the current main so it can pass the tests and github, workflows, etc. The pytest test-finding routine was finding duplicates in causal and...

Sorry about the long delay. We should be able to get this going again. The main issue seemed to be the name `harmonic_diameter`. We agree that computing average distances using...

We don't support 0-D sparse arrays. So I think this slipped through our shape checking changes. That will still not make it conform to array_api, but it will be a...

Additional tests (and maybe tests of what we don't support) would naturally go into the `scipy.sparse` module `scipy/sparse/tests/test_array_api.py`

I'm thinking about what a 0D sparse array would look like. I think we would just want to make numpy ndarray 0D arrays be the sparse array 0D arrays. They...

I guess you mean: you're not comfortable saying "np **scalars** are 0d arrays". The option of: `sparse.csr_array(int()) -> 1x1 sparse array` matches what sparse_matrix does: treating 0d input as 2d...