Johannes Schindelin

Results 878 comments of Johannes Schindelin

> I implemented this in [#114](https://github.com/msys2/msys2-runtime/pull/114) but did not really have time to validate that it does what it is supposed to do. I have now rebased this onto MSYS2...

@Botato300 sounds like you could already open a Pull Request!

Range-diff relative to pre-force-push * 1: 5242b29 ! 1: 6db6522 getViaGit: get minimal flavor from ci-artifacts ``````diff @@ Metadata Author: Dennis Ameling ## Commit message ## - getViaGit: get minimal...

> The message on that commit seems to be acknowledging that conversion of arguments is also problematic, so I'm not sure why it doesn't disable that as well. The commit...

> Don't you think you should double-check this before saying it? And how exactly are you imagining it works in Cygwin? > > https://github.com/mirror/newlib-cygwin/blob/fe2545e9faaf4bf9586f61a7b83d5cb5af501194/winsup/utils/mingw/strace.cc#L344-L345 I stand corrected regarding the first...

> And how exactly are you imagining it works in Cygwin? Sorry, I forgot to answer that question: Cygwin plays it safe and does the double-conversion, I expect. I.e. when...

> > I stand corrected regarding the first parameter (*argv, which is strace.exe itself). > > [...] This is the code for launching the child process. It is not modifying...

For lurkers, the Cygwin contribution can be seen [here](https://inbox.sourceware.org/cygwin-patches/[email protected]/#t).

@YO4 personally, I'd love to see the changes backported early into the MSYS2 runtime (once the jury has decided on `FILE_SUPPORTS_OPEN_BY_FILE_ID` that is, and the patches have stabilized).

> If msys2-runtime can be released with a new pkgrel before the next release of cygwin, I would like to see this PR merged. I see that the upstream version...