git-scm.com icon indicating copy to clipboard operation
git-scm.com copied to clipboard

broken links like “/docs/howto/update-hook-example”

Open Botato300 opened this issue 8 months ago • 2 comments

URL for broken page

https://git-scm.com/docs/howto/update-hook-example

Problem

In some cases, urls such as: https://git-scm.com/docs/howto/update-hook-example (which I found in the “Repository Administration” section of giteveryday)

make a redirect: https://github.com/git/git/blob/HEAD/Documentation/howto/update-hook-example.txt (with .txt at the end of the url) but this changed 4 months ago and now it ends in .adoc

If I am not mistaken, the problem is in this part of the code in the update-docs.rb file:

check_paths.each do |path|
        doc_path = "#{SITE_ROOT}external/docs/content/#{path}.html"
        if !File.exist?(doc_path)
          type = 'blob'
          target = path.sub(/^docs\//, '')
          if target == 'api-index'
            type = 'tree'
            target = 'technical'
          elsif target == 'howto-index'
            type = 'tree'
            target = 'howto'
          else
            target += '.txt' -- PROBLEM HERE: change to .adoc
          end
          front_matter = { "redirect_to" => "https://github.com/git/git/#{type}/HEAD/Documentation/#{target}" } # ltrim `docs/`
          FileUtils.mkdir_p(File.dirname(doc_path))
          File.open(doc_path, "w") do |out|
            out.write(wrap_front_matter(front_matter))
          end
        end
`

Botato300 avatar May 19 '25 08:05 Botato300

@Botato300 sounds like you could already open a Pull Request!

dscho avatar May 20 '25 08:05 dscho

@Botato300 sounds like you could already open a Pull Request!

I tried to make a Pull Request but it gave me an error so I backed out... I'll try again

Botato300 avatar May 20 '25 14:05 Botato300