Johannes Schindelin
Johannes Schindelin
But why submit _both_ this _and_ https://github.com/gitgitgadget/git/pull/617, _after_ sending https://lore.kernel.org/git/[email protected]/? In total, you submitted this patch three times now. I am not sure that reviewers like to be prodded like...
/allow
@cuishuang You will probably be asked for a couple of changes if you submit this directly, as-is: - Explain in the cover letter how you found those typos. - If...
> done Unfortunately not... (and you can force-push, no need to open another PR). You will need to use your real name and real email address, as per https://git-scm.com/docs/SubmittingPatches#dco.
You do not have to explain this _to me_. As I pointed out in my comment, this needs to be explained _in the commit message_. @mikeg98 you opened a PR....
`/submit` time?
> > > > `/submit` time? > > My understanding is that the next step is to write a comment with /submit', correct? Thanks First time I do this Yes....
> > > There is an issue in commit [ab05693](https://github.com/git/git/commit/ab05693b5bcb2fe564cf48839870a71d3940a0ac): > Commit checks stopped - the message is too short @klebertarcisio please have a look at the existing (non-merge) commit...
> > @klebertarcisio please have a look at the existing (non-merge) commit messages, and imitate them. > > Hi @dscho, thanks for the feedback. Now it's ok. Yep! Maybe even...