Johannes Schindelin
Johannes Schindelin
This looks pretty good now. While I am not sure that the core developers on the Git mailing list will like the bundled `IPC::Run` (and will likely suggest to load...
> Maybe I should copy the thoughts from above into that cover mail though :) Might make a ton of sense :-)
> > > Update git-gui.ico and git-gui.icns with bitmaps of higher resolution. > Call "wm iconphoto" with images created from PNG bitmaps on macOS. > > Signed-off-by: Kirill Gavrilov [[email protected]](mailto:[email protected])...
Thank you for your contribution! A couple of pointers how to improve this patch before sending it off to the Git mailing list: - please review the history of the...
/allow
> There is an issue in commit [2e9a205](https://github.com/git/git/commit/2e9a205d861850d04d8156d4fdc665bf36ae4e22): > Commit checks stopped - the message is too short This commit should be squashed into https://github.com/git/git/pull/1141/commits/28629862a897e66c488ca69bb0fbdd546f8b6d9d (e.g. via `git rebase -i`...
> the commit mesage needs to be improved More concretely, compare this: ``` Fix example `want`s must be _flushed_ with `0000` before `have`s ``` to this: ``` http-protocol.txt: document SHA-256...
> the commit mesage needs to be improved Oh, and you do that via `git commit --amend`. Afterwards, you will have to [force-push](https://git-scm.com/docs/git-push#Documentation/git-push.txt--f) your `patch-1` branch, to update this PR.
> > > I was using GitHub web editor. Looks like I have to clone the repo locally and then force push. Looks like it! Having said that, can't you...