David Sheldrick

Results 262 comments of David Sheldrick

This never got done 😢 but y'all should give it another go at some point! Gonna close it to clear my open PRs.

Thanks for the report, and for submitting a repro :heart: This issue slipped off my radar, apologies for that. I'll try to take a look some time this week.

Just had a very quick look, one thing we discovered the other day was that the `target` and `module` options in tsconfig.json are important for hot reloading. You need to...

At the moment, this transformer uses babel as a secondary transpiler, so the only limitation is that the `target` needs to be supported by the babel config in your project....

I should just make the transformer overwrite the `target` and `module` options to prevent these issues in the future.

Hmmmm good point. I hadn't considered that. I know it's possible to use babel as a secondary transpilation step with ts-jest too, maybe I should encourage that. Otherwise, yes, the...

Hi! Thanks for the report! :) I tried it and found a similar error, so it's not just you at least. The normal react-native debugging works (I tried with the...

Ah, yes, we can see that the tsconfig loading strategy is [embarrassingly naïve](https://github.com/ds300/react-native-typescript-transformer/blob/b4aa298154c7228937323a344418666694ddc241/index.js#L37). I'll switch to [TypeStrong/tsconfig](https://github.com/TypeStrong/tsconfig) asap. Thanks for the report!

Hmm, didn't realise that `TypeStrong/tsconfig` also doesn't support the `"extends"` option. https://github.com/TypeStrong/tsconfig/issues/21 Will have to do some more digging. Maybe I can use whatever TS itself uses to load config...

Yes! Babel 7 can transpile TypeScript, which is **amazing** and makes this library obsolete. Couldn't be happier to have a thing I've built become useless :D