Daniel Young

Results 11 comments of Daniel Young

A few questions: 1. Is there a way to check the output of the output of the formatting script? 2. It appeared that the builds failed for MacOS because of...

> Hello! I just approved the CI checks again, but I believe that for those changes you should also be able to check the CI tests in your forked repo,...

@jufajardini Definitely. Thanks for the advice! Any idea why the build scripts aren't running on my machine? ``` ➜ suricata git:(whitespace-bug) ./scripts/clang-format.sh whitespace-bug ./scripts/clang-format.sh: command substitution: line 395: syntax error...

> No need to replace `branch` with your branch-name there. Would that help? Same issue actually 🤔

> > > No need to replace `branch` with your branch-name there. Would that help? > > > Same issue actually thinking > > Talkin about versions... what's your clang...

Looking at my output from the error, it really looks like an issue with the do...case statement in the bash script. I'll keep debugging. I was able to get the...

@victorjulien @jufajardini Looks like the 2 "fuzzer" checks are failing, but everything else is passing. It's giving me the following error: ``` + cd .. + export CARGO_BUILD_TARGET=x86_64-unknown-linux-gnu + CARGO_BUILD_TARGET=x86_64-unknown-linux-gnu...

With regards to the Fedora 35 build that's failing, can you please rerun it? It appears it might not be deterministic as it passed in my branch https://github.com/drypycode/suricata/runs/6599842582?check_suite_focus=true Also note...

@jufajardini Could use some clarification on what you want me to do here. As far as I can tell, these builds are not deterministic between my fork's PR and this...

@victorjulien anything I can do to help get this into master?