Dries Van De Putte
Dries Van De Putte
I removed them in my latest commit to #233 . Changed the title to reflect what we need to do after the merge.
Yes, this should probably be a new version. Not only because of the API changes, but also because the instrument packs are an entirely new concept, changing something fundamental about...
I just ran into a new issue, which turned out to be very relevant for this. I was working with my experimental branch, where I try to mitigate these kinds...
I have been cleaning up my code and testing some more things. For the stellar continuum, we can probably get away with a simple constant (unit) as the normalization. However...
I changed a use of `trapz` to `trapezoid` to avoid a deprecation warning from numpy. But apparently that's a numpy 2.0 thing. If require numpy >=2.0 as a dependency, that...
I pushed some changes. For the numpy trapz (=2.0.0) issue, I have found a workaround: use scipy.integrate.trapezoid instead. To deal with the flux/intensity split, there will have to be some...
The ratio matters because it affect the value of `intensity_amplitude_factor`, e.g. in this code ``` intensity_amplitude_factor = ( (2 * units.intensity_power * units.wavelength / (constants.c * np.pi)) .to(units.intensity) .value )...
I reread the comments and looked over my code changes again, and I think no more changes are needed at this point. I think we can merge to dev, and...
I have been wondering about this, and the spectrum you show looks like an interesting test case! I would say it depends on how you want your assumptions to be....
Seeing a double plot is just a quirk of how notebooks work, and it happens because model.plot() returns the figure object. I usually avoid this by writing `_ = model.plot(...)`....