Dries Van De Putte

Results 36 comments of Dries Van De Putte

I copied a selection of comments from this discussion https://github.com/PAHFIT/pahfit/pull/281#issuecomment-2101084989, as a reminder for when I put in the Fitter framework. > I think keep it simple with a string-based...

Note of general caution: with the format used in #283 (recently merged into dev), be very careful when assigning values! The right way to access an element of the bounds...

I just updated the title of this issue. We can write down everything going wrong with the continuous integration services we're using, so we can fix it all in one...

I have spun up a test pull request for the switch to power units here https://github.com/drvdputt/pahfit/pull/1/files. It's pointed to drvdputt/dev-fitterapi on my own fork, so I can see what is...

Most of this has been addressed now that #289 and #295 were merged. And most remaining discussion points are addressed in new, separate issues. Closing this.

Ok, I will review the above three pull requests. I'll post another comment here once I'm done with this, and then we'll pull those into dev. I will then test...

Yes, we have a different approach in the other pull request now. Closing.

Based on questions in #254 , we should really have an explicit explanation of how to use fwhm fitting instead of instrument pack values. I don't think it's intuitive to...

Thank you for reminding me of this restriction I put in. I did this because there is some code that can't deal with a single-component model. (The resulting astropy model...

`sub_model` does not exist anymore, and its replacement `tabulate()` works for a single component (as tested with the current state of the dev branch). This issue can therefore be closed.