Piotr Sarnacki

Results 12 comments of Piotr Sarnacki

I would merge this, but it changes get to limit records to 100. While I agree that getting all of the records is probably not something that you want to...

I agree that this could be done better, but there is no easy mechanism for that in Rails. Basically when you have validations and callbacks you can't just always update...

I am all for making this Rack based instead of only Rails based, but I didn't want to start from that as it is still a bit of experiment -...

It turns out that the problem was caused by `.gitignore` entries. The following works correctly: ``` node_modules bower_components ``` But this form fails: ``` /node_modules /bower_components ``` I'm still not...

Thanks for all the investigation. I've run into it as well and ideally the solution would be similar to what Go does, ie. wait for closing a read stream (ie....

Thanks for explanation and now it makes total sense, I was blinded too much by my benchmarking tries to actually realize that it will work the same as most async...

Are there any updates on these issues? I'd be happy to help if there's still something left to do.

> I think this generally lgtm, nil values generally shouldnt be allowed in span attributes was my understanding though, If that's the case I think a better fix would be...

Sorry for no activity here. I'll work on a fix, but there's also another problem that I've found - it will also fail when the value can't be mapped to...