Heikki Hellgren
Heikki Hellgren
Looking like a good start but we do need tests fixed + added for this feature
@billyatroadie I don't think it needs to be a major bump as the API will backwards compatiable. Does, for example @freben, or some other maintainer have thoughts on the versioning?
@billyatroadie I think the rebase has messed up this PR 🤔
Just a reminder, after this we need to modify also #29259
@awanlin makes sense. Though I would move those to `react` plugin (if they are not yet, can't remember the details) instead as frontend plugin depending on another frontend plugin is...
@Dharmil4602 just remember if there is need to move some already exported component from `notifications` to `notifications-react`, remeber to re-export those and mark as deprecated in the `notifications` to not...
Noticed that also the settings card could be moved to react plugin. That's at least one component that is exported already from the notifications plugin itself and needs a deprecated...
You want to re-export the deprecated components in the `notifications` plugin. So you should add the following to the `notifications/src/deprecated.ts`: ```ts import { UserNotificationSettingsCard as UserNotificationSettingsCardTemp } from '@backstage/plugin-notifications-react'; /**...
@Dharmil4602 rhe routeRef should stay in the frontend package as well as the NotificationPage. But other components can be moved to the react plugin
Not stale, still seeing this from time to time