yangw

Some people may still use v1beta1. IMO, we still need conversion in a period of time.

I'm not familiar with the `conversionReviewVersions` mechanism; maybe need help.@shubham-cmyk

@mrhovunping As described in https://github.com/kubernetes/kubernetes/issues/82782#issuecomment-532202230, you can also use imagePullSecrets for initcontainers && sidecars.

Thank you, @wkd-woo, for your feedback. We should support the old master redis to rejoin the cluster after failover.

Hey @maheshglm! The issue stems from the redis sentinel controller reconciliation mechanism. Redis sentinel reconciles every 10 seconds. When you kill a pod, it becomes the master pod. The sentinel...

Hey @maheshglm! Could you please verify if the sentinel pod is recreated after you kill the master pod? If the sentinel pod is not created, that's the expected behavior.

> When will this PR be applied? I'm waiting on it. @iamabhishek-dubey @shubham-cmyk @drivebyer It appears to be in a Draft state at the moment. I am not sure if...

Thank you for your contribution. Could you please address the `DCO` and `Semantic PR Validation` issues? @takara9

IMO, it might not be the Master IP, because it's in the StatefulSet spec's template field. According to the error message: `"error": "StatefulSet.apps 'redis-sentinel-engine-sentinel' is invalid: spec: Forbidden: updates to...

try this 1. build operator from the latest code 2. apply https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/tests/e2e-chainsaw/v1beta2/nodeport/redis-cluster/cluster.yaml