redis-operator icon indicating copy to clipboard operation
redis-operator copied to clipboard

Add imagePullSecrets for initcontainers and sidecar

Open mrhovunping opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. I would like to sidecar a container to redis pod, the container is on a private repository, thus needs a cred to pull it. As I see there is no imagePullSecrets tag on initcontainers and sidecars on the redis-replication crd as well as redis-cluster, redis-standalone and redis-sentinel crds.

Describe the solution you'd like Add support of imagePullSecrets tag on initcontainers and sidecars

Describe alternatives you've considered As of now no quick solution as I am not the owner of the private repository.

What version of redis-operator are you using?

redis-operator version: 0.15.9

Additional context

mrhovunping avatar Nov 29 '23 05:11 mrhovunping

Thanks for using redis-operator we would add iamgepullSecret for the sidecars and init Containers

shubham-cmyk avatar Nov 30 '23 20:11 shubham-cmyk

@mrhovunping As described in https://github.com/kubernetes/kubernetes/issues/82782#issuecomment-532202230, you can also use imagePullSecrets for initcontainers && sidecars.

drivebyer avatar Jan 14 '24 08:01 drivebyer