Dominik Ritter

Results 11 issues of Dominik Ritter

- Remove code that made the false assumption that if dragging an element out of the greedy child, it is always over the parent. This is not always true, as...

Bug
Comp: Droppable

Hi there! ESBuild released a new [Version](https://github.com/evanw/esbuild/releases/tag/v0.15.0), supporting PnP. This PR updates the Docs. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing).

This is my fourth iteration on async functionality and adds such (currently based solely on ZSH-Async) to every segment that is tagged as `async`. So, opposed to our earlier approaches,...

Hi! There is a small typo in the Project description: ![image](https://user-images.githubusercontent.com/1544760/106941101-adf51080-6722-11eb-9e36-6a83c9028bc4.png) It should be "support".

We encountered a strange Bug with `amp-lightbox` closes automatically if the user switches Tabs in Chrome. ![amp-lightbox--autoclose](https://user-images.githubusercontent.com/1544760/104499190-ffefbe00-55dc-11eb-8f1f-86b4c9346a1e.gif) ### Reproducer See [Reproducer in AMP-Playground](https://playground.amp.dev/?format=websites&_gl=1*1x3bd84*_ga*YW1wLUVvY0x0M0JNTndrU1NvZS11S0NfZ2c.&mode=Responsive&preview=true#share=PCEtLQogICMjIEludHJvZHVjdGlvbgoKICBUaGUgW2BhbXAtbGlnaHRib3hgXSgvY29udGVudC9hbXAtZGV2L2RvY3VtZW50YXRpb24vY29tcG9uZW50cy9yZWZlcmVuY2UvYW1wLWxpZ2h0Ym94LXYwLjEubWQpIGNvbXBvbmVudCBhbGxvd3MgZm9yIGEg4oCcbGlnaHRib3jigJ0gb3Igc2ltaWxhciBleHBlcmllbmNlIC0gd2hlcmUgdXBvbiB1c2VyIGludGVyYWN0aW9uIGEgY29tcG9uZW50IGV4cGFuZHMgdG8gZmlsbCB0aGUgdmlld3BvcnQsIHVudGlsIGl0IGlzIGNsb3NlZCBhZ2FpbiBieSB0aGUgdXNlci4KLS0+PCEtLSAtLT4KPCFkb2N0eXBlIGh0bWw+CjxodG1sIOKaoSBsYW5nPSJlbiI+CjxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgiPgogICAgPHRpdGxlPmFtcC1saWdodGJveDwvdGl0bGU+CiAgICA8c2NyaXB0IGFzeW5jIHNyYz0iaHR0cHM6Ly9jZG4uYW1wcHJvamVjdC5vcmcvdjAuanMiPjwvc2NyaXB0PgogICAgPHNjcmlwdCBhc3luYyBjdXN0b20tZWxlbWVudD0iYW1wLWNhcm91c2VsIiBzcmM9Imh0dHBzOi8vY2RuLmFtcHByb2plY3Qub3JnL3YwL2FtcC1jYXJvdXNlbC0wLjEuanMiPjwvc2NyaXB0PgogICAgPHNjcmlwdCBhc3luYyBjdXN0b20tZWxlbWVudD0iYW1wLWxpZ2h0Ym94IiBzcmM9Imh0dHBzOi8vY2RuLmFtcHByb2plY3Qub3JnL3YwL2FtcC1saWdodGJveC0wLjEuanMiPjwvc2NyaXB0PgogICAgPGxpbmsgcmVsPSJjYW5vbmljYWwiIGhyZWY9Imh0dHBzOi8vYW1wLmRldi9kb2N1bWVudGF0aW9uL2V4YW1wbGVzL2NvbXBvbmVudHMvYW1wLWxpZ2h0Ym94L2luZGV4Lmh0bWwiPgogICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCI+CiAgICA8c3R5bGUgYW1wLWJvaWxlcnBsYXRlPmJvZHl7LXdlYmtpdC1hbmltYXRpb246LWFtcC1zdGFydCA4cyBzdGVwcygxLGVuZCkgMHMgMSBub3JtYWwgYm90aDstbW96LWFuaW1hdGlvbjotYW1wLXN0YXJ0IDhzIHN0ZXBzKDEsZW5kKSAwcyAxIG5vcm1hbCBib3RoOy1tcy1hbmltYXRpb246LWFtcC1zdGFydCA4cyBzdGVwcygxLGVuZCkgMHMgMSBub3JtYWwgYm90aDthbmltYXRpb246LWFtcC1zdGFydCA4cyBzdGVwcygxLGVuZCkgMHMgMSBub3JtYWwgYm90aH1ALXdlYmtpdC1rZXlmcmFtZXMgLWFtcC1zdGFydHtmcm9te3Zpc2liaWxpdHk6aGlkZGVufXRve3Zpc2liaWxpdHk6dmlzaWJsZX19QC1tb3ota2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUAtbXMta2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUAtby1rZXlmcmFtZXMgLWFtcC1zdGFydHtmcm9te3Zpc2liaWxpdHk6aGlkZGVufXRve3Zpc2liaWxpdHk6dmlzaWJsZX19QGtleWZyYW1lcyAtYW1wLXN0YXJ0e2Zyb217dmlzaWJpbGl0eTpoaWRkZW59dG97dmlzaWJpbGl0eTp2aXNpYmxlfX08L3N0eWxlPjxub3NjcmlwdD48c3R5bGUgYW1wLWJvaWxlcnBsYXRlPmJvZHl7LXdlYmtpdC1hbmltYXRpb246bm9uZTstbW96LWFuaW1hdGlvbjpub25lOy1tcy1hbmltYXRpb246bm9uZTthbmltYXRpb246bm9uZX08L3N0eWxlPjwvbm9zY3JpcHQ+CiAgICA8c3R5bGUgYW1wLWN1c3RvbT4KICAgICAgICAubGlnaHRib3ggewogICAgICAgICAgICBiYWNrZ3JvdW5kOiByZ2JhKDAsMCwwLDAuOCk7CiAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgICAgICBoZWlnaHQ6IDEwMCU7CiAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICAgICAgZGlzcGxheTogZmxleDsKICAgICAgICAgICAgYWxpZ24taXRlbXM6IGNlbnRlcjsKICAgICAgICAgICAganVzdGlmeS1jb250ZW50OiBjZW50ZXI7CiAgICAgICAgfQogICAgICAgIC5saWdodGJveCBoMSB7CiAgICAgICAgICAgIGNvbG9yOiB3aGl0ZTsKICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoKPGRpdj4KICAgIDxhbXAtbGlnaHRib3ggaWQ9Im15LWxpZ2h0Ym94IiBsYXlvdXQ9Im5vZGlzcGxheSI+CiAgICAgICAgPGRpdj4KICAgICAgICAgICAgPGFtcC1jYXJvdXNlbCBpZD0ibGlnaHRib3gtY2Fyb3VzZWwiCiAgICAgICAgICAgICAgICAgICAgICAgICAgaGVpZ2h0PSIzIgogICAgICAgICAgICAgICAgICAgICAgICAgIHdpZHRoPSI0IgogICAgICAgICAgICAgICAgICAgICAgICAgIGxheW91dD0icmVzcG9uc2l2ZSIKICAgICAgICAgICAgICAgICAgICAgICAgICBsb29wCiAgICAgICAgICAgICAgICAgICAgICAgICAgdHlwZT0ic2xpZGVzIj4KICAgICAgICAgICAgICAgIDxhbXAtaW1nIHNyYz0iaHR0cHM6Ly9wbGFjZWhvbGQuaXQvNDAweDMwMD8xIgogICAgICAgICAgICAgICAgICAgICAgICAgd2lkdGg9IjQwMCIKICAgICAgICAgICAgICAgICAgICAgICAgIGhlaWdodD0iMzAwIgogICAgICAgICAgICAgICAgICAgICAgICAgYWx0PSJhIHNhbXBsZSBpbWFnZSI+PC9hbXAtaW1nPgogICAgICAgICAgICAgICAgPGFtcC1pbWcgc3JjPSJodHRwczovL3BsYWNlaG9sZC5pdC80MDB4MzAwPzIiCiAgICAgICAgICAgICAgICAgICAgICAgICB3aWR0aD0iNDAwIgogICAgICAgICAgICAgICAgICAgICAgICAgaGVpZ2h0PSIzMDAiCiAgICAgICAgICAgICAgICAgICAgICAgICBhbHQ9ImFub3RoZXIgc2FtcGxlIGltYWdlIj48L2FtcC1pbWc+CiAgICAgICAgICAgICAgICA8YW1wLWltZyBzcmM9Imh0dHBzOi8vcGxhY2Vob2xkLml0LzQwMHgzMDA/MyIKICAgICAgICAgICAgICAgICAgICAgICAgIHdpZHRoPSI0MDAiCiAgICAgICAgICAgICAgICAgICAgICAgICBoZWlnaHQ9IjMwMCIKICAgICAgICAgICAgICAgICAgICAgICAgIGFsdD0iYW5kIGFub3RoZXIgc2FtcGxlIGltYWdlIj48L2FtcC1pbWc+CiAgICAgICAgICAgIDwvYW1wLWNhcm91c2VsPgogICAgICAgICAgICA8YSBvbj0idGFwOm15LWxpZ2h0Ym94LmNsb3NlIj4KICAgICAgICAgICAgICAgIENsb3NlIExpZ2h0Ym94CiAgICAgICAgICAgIDwvYT4KICAgICAgICA8L2Rpdj4KICAgIDwvYW1wLWxpZ2h0Ym94PgoKICAgIDxhbXAtY2Fyb3VzZWwgaGVpZ2h0PSIxMDAiCiAgICAgICAgICAgICAgICAgIGxheW91dD0iZml4ZWQtaGVpZ2h0IgogICAgICAgICAgICAgICAgICB0eXBlPSJzbGlkZXMiCiAgICA+CiAgICAgICAgPGEgb249InRhcDpteS1saWdodGJveC5vcGVuIj4KICAgICAgICAgICAgPGFtcC1pbWcgc3JjPSJodHRwczovL3BsYWNlaG9sZC5pdC80MDB4MzAwPzEiCiAgICAgICAgICAgICAgICAgICAgIHdpZHRoPSIxNTAiCiAgICAgICAgICAgICAgICAgICAgIGhlaWdodD0iMTAwIgogICAgICAgICAgICAgICAgICAgICBhbHQ9ImEgc2FtcGxlIGltYWdlIj48L2FtcC1pbWc+CiAgICAgICAgPC9hPgogICAgICAgIDxhIG9uPSJ0YXA6bXktbGlnaHRib3gub3BlbiI+CiAgICAgICAgICAgIDxhbXAtaW1nIHNyYz0iaHR0cHM6Ly9wbGFjZWhvbGQuaXQvNDAweDMwMD8yIgogICAgICAgICAgICAgICAgICAgICB3aWR0aD0iMTUwIgogICAgICAgICAgICAgICAgICAgICBoZWlnaHQ9IjEwMCIKICAgICAgICAgICAgICAgICAgICAgYWx0PSJhbm90aGVyIHNhbXBsZSBpbWFnZSI+PC9hbXAtaW1nPgogICAgICAgIDwvYT4KICAgICAgICA8YSBvbj0idGFwOm15LWxpZ2h0Ym94Lm9wZW4iPgogICAgICAgICAgICA8YW1wLWltZyBzcmM9Imh0dHBzOi8vcGxhY2Vob2xkLml0LzQwMHgzMDA/MyIKICAgICAgICAgICAgICAgICAgICAgd2lkdGg9IjE1MCIKICAgICAgICAgICAgICAgICAgICAgaGVpZ2h0PSIxMDAiCiAgICAgICAgICAgICAgICAgICAgIGFsdD0iYW5kIGFub3RoZXIgc2FtcGxlIGltYWdlIj48L2FtcC1pbWc+CiAgICAgICAgPC9hPgogICAgPC9hbXAtY2Fyb3VzZWw+CjwvZGl2Pgo8L2JvZHk+PC9odG1sPgo=) If you click on the first slide,...

Type: Bug
P3: When Possible
WG: components
Component: amp-lightbox
Stale

In the config it might be handy to use a regular expression instead of a wildcard. It would be nice to do something like: ``` xml ``` That should match...

enhancement

Hi there! This is a clumsy approach to treat arrow functions equal to regular function declarations. I usually write my functions as arrow functions like so (as a matter of...

### I am interested in helping provide a fix! Yes ### Which generators are impacted? - [X] All - [ ] Angular - [ ] HTML - [ ] Qwik...

bug

### I am interested in helping provide a fix! Yes ### Which generators are impacted? - [X] All - [ ] Angular - [ ] HTML - [ ] Qwik...

bug

Hi there! In my project rollup complains about deep-value not being a proper module. I know there are plugins for various module bundlers that allow including a commonjs module (like...