Results 95 comments of Aldrin M

I think more context about the interaction with `ExtendedExpressionRel` would be helpful. I commented on #794 (moved my comment from here).

I accommodated feedback from @vbarua and rebased on main

@tokoko @vbarua as long as `planrel_reference` is a new field in `ReferenceRel` anyways, what if we actually nest it in a `oneof`, that way we can be explicit about other...

I'm not sure if this is actually a bug or if something I used to do is no longer valid. Note that this code was working prior to the large...

sure, I can do that by end of day tomorrow.

turns out by "tomorrow" I meant "in 2 days". here's sample code that reproduces it for me: https://gist.github.com/drin/ecbf5ed90de749e420eafbdd70a76750 [lines 45-52][code-error] represents an unrolled loop where the error is thrown, and...

I randomly found this and just wanted to chime in: I think this sounds like a great idea and moving the old repr to an `explain` function or something similar...

More generally speaking, there is no currently existing example that is interesting. To make an interesting one depends on a database having an interesting way of querying a view. I...

> A join relation with Join Expression X and Post-Join Filter Y is equivalent to a join relation with Join Expression X AND Y Is this strictly true? As in...

There is a thread that discusses the description that would go in the website: [discussion on website description](https://github.com/substrait-io/substrait/pull/807/files/3ad21f6088cc2aadf7ab2f2bc423195244bb3a9d#diff-83876a457ee3e771d6e6d242bf0dced12cb0b20961bdffe744d6ad60dd92eed5) I think further discussion on this can be deferred until agreement on...