Aldrin M comments

Results 95 comments of


                                            Aldrin M

GH-17211: [C++] Add hash_64 scalar compute function

rebased on main branch

GH-17211: [C++] Add hash_64 scalar compute function

@judahrand, I wanted to verify something with you since I assume you have an immediate use case in mind for #32504 . The naive implementation of hashing for a "shallow"...

GH-17211: [C++] Add hash_64 scalar compute function

An alternate approach is to return a ```cpp Status::NotImplemented("Cannot hash nested data types with many levels of nesting") ``` if any of the columns to hash are "deep" nested types.

GH-17211: [C++] Add hash_64 scalar compute function

> I'm not entirely sure I've understood your distinction between the two cases. Am I correct in understanding that in the first of the two options that you describe a...

GH-17211: [C++] Add hash_64 scalar compute function

Closing this PR in favor of #45001 .

GH-17211: [C++] Add `hash32` and `hash64` scalar compute functions

@zanmato1984 @pitrou if you have any time, could you review this? the relevant issue (#17211) got flagged as stale, but I think this is still desirable

feat: add anchor for non-ordinal plan reference

I should have time to finish this up in the next few days

feat: add anchor for non-ordinal plan reference

rebased on main

feat: add anchor for non-ordinal plan reference

hm, according to [a stackoverflow post][web-so-protobuf-breakingchange], moving an optional field into a `oneof` is not breaking. This PR essentially makes `subtree_ordinal` an optional field instead of an implicit field by...

feat: add anchor for non-ordinal plan reference

> By making the anchor on the plan object... I think you may be misunderstanding where the anchor is? I don't think of the PlanRel as the Plan object >...