Gert Driesen

Data-driven tests are not fully supported for overloaded test methods

12

## Description The MSTest V2 test framework does not appear to correctly support overloaded data-driven test methods. Only tests for the first overload are actually found and executed. ## Steps...

Fix S2589 FP: When local is assigned in for loop

4

### Description When a local variable is initialized in a for loop, then **S2589** reports a false positive if you check whether the local variable has a value. ### Repro...

Some exception classes are marked internal [API-2052]

3

Currently, the following exception classes have **internal** accessibility: * TransactionTimedOutException * TransactionNotActiveException * TransactionException * AuthenticationException This means that it's not possible to have a catch block in which you...

Add a bool TryGet(TKey key, out TValue value) method to IMap [API-2049]

3

Right now when the value of a map is a primitive (not-nullable) type, the following code must be used to verify if there's a value for a given key and...

Implement memory-based overloads on SftpFileStream

1

We should implement the following overloads on **SftpFileStream**: * [ReadAsync(Memory buffer, System.Threading.CancellationToken cancellationToken = default)](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readasync?view=net-7.0#system-io-stream-readasync(system-memory((system-byte))-system-threading-cancellationtoken)) * [WriteAsync(ReadOnlyMemory buffer, System.Threading.CancellationToken cancellationToken = default)](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.writeasync?view=net-7.0#system-io-stream-writeasync(system-readonlymemory((system-byte))-system-threading-cancellationtoken)) When this is done, remove the [CA1844](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1844) suppression...

Similar to what we do for **AsyncResult**, we should only initialize the **WaitHandle** we need to wait for the operation to complete. We should add a `Wait(TimeSpan)` method to **Token**,...

SshCommand: OutputStream & ExtendedOutputStream should only return 0 when channel is closed

3

Invoking `Read(Byte[], Int32, Int32)` on SshCommand*'s **OutputStream** or **ExtendedOutputStream** should blocking until either data is available, or the channel is closed (in which case zero should be returned). We should...

Shell's IDisposable implementation must dispose input stream if we own it

2

We have a few `CreateShell(...)` overloads on **SshClient** were we create the input stream that we pass to **Shell**. When the **Shell** instance is disposed, we should dispose that input...

Fix typo in SftpFileSytemInformation class name

3

Notice that we have a typo in the name of this class. @WojciechNagorski @Rob-Hague: Do we fix this?

**ForwardedPortDynamic** defines a public `Dispose()` method, but does not implement **IDisposable**. Its base class, **ForwardedPort**, defines a protected `Dispose(bool disposing)` method. We should update **ForwardedPort** to implement **IDisposable**.