Gert Driesen

Results 22 comments of Gert Driesen

Are you afraid it's not correct? I was already convinced from the docs (**RanToCompletion** = "The task completed execution successfully."), but added unit tests just to be 100% sure.

These have an underlying flags enum (called **m_stateFlags**). In that enum you **can** have the **RanToCompletion** flag set in a combination with **Canceled** or **Faulted**. Which is why in **Status**,...

@lahma I'm preparing a PR for this (and a few other changes), but I wonder why we do not have an **IdleWaitTime** property on **QuartzSchedulerResources**. Instead it is passed as...

@lahma Can you point to me to the code where we dynamically set this property on **QuartzSchedulerThread**?

Don't you just love serialization magic ... :(

@lahma I'm not asking this specifically for this PR (but your answer could drive what we decide to do with this one), but is it ok to achieve backward compatibility...

@lahma Have you already shipped a version with nullable annotations? We're not very "honest" about the nullability characteristics on several properties.

@lahma, there's a lot to digest here. Let me know if you want me to split this up in multiple issues. I'm not saying we should update our implementation for...

For all **IJobStore** implementation that we ship, it can only happen for **RAMJoreStore** and this only in one of the following cases: * The acquired trigger has been deleted since....

Thanks for the fast feedback!! I do not plan to introduce any breaking changes, even though - as you mentioned - changing some methods to return concrete types, or take...