Drew Hamilton

Results 14 comments of Drew Hamilton

Right now running in `scenario.onActivity` causes a crash: "java.lang.RuntimeException: java.lang.RuntimeException: This method can not be called from the main application thread" This makes some sense, because the `onActivity` callback runs...

True! This is what we're doing in the meantime. But the ActivityScenario documentation [explicitly says not to do this](https://developer.android.com/reference/androidx/test/core/app/ActivityScenario#onactivity) so we'd better add real support before the ActivityScenario police find...

Yep totally get it. I'll try a contribution soon, just worried I'll get stuck since I don't know the code base. The workaround suffices in the meantime.

Just my 2¢: I would recommend against releasing `ActivityScenarioUtils.waitForActivity` as part of your public API. It seems way outside of Shot's responsibilities to get an Activity instance from an ActivityScenario...

Hmm, is that [these lines](https://github.com/facebook/screenshot-tests-for-android/blob/master/core/src/main/java/com/facebook/testing/screenshot/internal/ScreenshotImpl.java#L150-L151) in Facebook's library? Or is there more to it? If so I'd like to file an issue and/or PR to that repo to make TestNameDetector...

I came here to file an issue that protected functions in sealed classes should not be reported, and found this similar issue. Do you want to consider that as part...

The unstable 3rd-party class scenario seems unusual compared to the scenario where 3rd-party classes are assumed stable and, as @ansman mentions, you don't want the false impression that you're breaking...

This is from the IDE's built-in coverage tool, right? As opposed to a Jacoco Gradle plugin or something? What version of the IDE and AGP are you using? Does the...

Looks like this could be done with Dependabot if dependabot/dependabot-core#3121 is implemented

> \* What went wrong: Execution failed for task ':kotlinStoreYarnLock'. \> Lock file was changed. Run the `kotlinUpgradeYarnLock` task to actualize lock file Want to give that a go?