Eric Drenckpohl
Eric Drenckpohl
Of course, I added @tpict as a co-author on the commit. I'll ping again sometime next week.
Thanks for finding this. I'll add unit tests and start looking for a fix.
@tpict do you have an example test case that breaks this implementation? This test passes: ``` test('should handle child selectors', () => { const actual = serialize( compile( `.some-class >...
Hmm this is also passing: ``` test('should handle child selectors', () => { const actual = serialize( compile( `.some-class { & > .some-child-class { color: green; } .some-parent-class > &...
I added unit tests covering different child selector cases and it's still working as expected.
Alright, I've had some time to dig into this and the problem seems to be with an interaction with the `compat` plugin. The broken selector example I'm using is `.class-one:focus...
It's also worth mentioning ``` .class-one:focus ~ &, .class-two:focus > & ``` is broken, but both ``` .class-one ~ &, .class-two > & ``` and ``` .class-one:focus ~ & ```...
Thanks, that context is helpful. I just pushed the changes with a broken unit test for each suite. The current version of the plugin is broken in both, due to...