William Chou
William Chou
On keyboard enter, don't select when filteredItems is empty. If `filteredItems` is empty array here: https://github.com/zurb/tribute/blob/252ec344a75b624268aef1cdbf80afc30b3cbe2b/src/TributeEvents.js#L226-L230 Then `item` will be undefined here: https://github.com/zurb/tribute/blob/252ec344a75b624268aef1cdbf80afc30b3cbe2b/src/Tribute.js#L473-L479 I noticed this when hitting the enter...
Integration tests in `test-amphtml-ads.js` are flaky on Headless Chrome in experiment B (INABOX_LITE): ``` DESCRIBE => A more real AMPHTML image ad DESCRIBE => ATF within friendly frame or safe...
### Background Currently, URLs inside the `style` attribute of `` descendants are rewritten as AMP cache URLs (on pages served from AMP cache). For example: ```html ``` ```html ``` This...
### Problem In some email implementations, the embedding iframe is sized according to "documentHeight" viewer messages sent from the AMP doc. This "documentHeight" can be highly variable while loading some...
Not a comprehensive list. As of writing, just the ones I encountered when trying to get "hello world" example to work on Vue 2.6.5 (dev). ### window.navigator.userAgent ``` Uncaught TypeError:...
For debug mode only, it might be nice to add a JS proxy that warns when setting unsupported properties. E.g. with a short-link to new issue template for `worker-dom`. Thinking...
**Suggestion**: Element tests in src/test/ should verify that `mutator.ts` is invoked with the correct params. Refactoring `mutator.ts` from module-level vars into a class would help mockability in unit tests. For...
E.g. we workaround `super.getter` (#332) to avoid an expensive transpile. It would be nice to have: 1. A linter to catch and ban future instances of `super.getter` pattern. 2. A...
We may be too optimistic in ignoring JS vs. TS typing issues in APIs, e.g. ```ts // Element.ts public setAttribute(name: string, value: string): void {...} ``` In this example, there's...
I noticed this surprising type error when testing todomvc in amp-script. After tapping a checkbox, the worker sends the following mutation: ```js { nodeName: "INPUT", attribute: "checked", value: true, }...