Results 379 comments of Chris Brown

The plugin infrastructure in 1.5.8 should handle some form of upgrade handling.

Were you thinking of capturing only a single tax-rate? How would you handle products having varying tax rates/classes?

Keep in mind that pulling mods into the core implicitly expects "us" to do all the support of the feature and maintain the feature. Are you volunteering to take on...

Before we go and make a bunch of code changes, what's the result of inspecting the impact on usability when making the change?

The best a progress-indicator could do is tell you what percentage of "statements have run". Unfortunately that's not realistic about "how long it will take". The actual culprit is the...

Looks good to me. 👍

@napestershine I believe this bug can be fixed with this change: `src/Vendor/Laravel/ServiceProvider.php` ```diff protected function registerTracker() { - $this->app->singleton('tracker', function ($app) { + $this->app->singleton(Tracker::class, function ($app) { $app['tracker.loaded'] = true;...

Workaround: for temporary dev-only use, I just removed those custom things, and the package generated factories normally without error. 👍 But if this were to be run in some automated...