Daniel McCloy

Results 826 comments of Daniel McCloy

> Can we add @isabela-pf to the repo (even only with read access) so that we can assign her to review ? invitation sent!

> I likely need to use font-awesome 6 instead of 5. or even [octicons](https://primer.style/components/icon#specific-use-cases)? I think a complete set for us would be: - PR open - PR closed (unmerged)...

> We should be using FA 6 (this is the one we are vendoring with the theme). Also despite my earlier comment about octicons, I won't object to using FA6...

here's a screenshot of how this will look: ![Screenshot 2024-09-19 at 13-31-46 Update our kitchen sink — PyData Theme 0 15 4dev0 documentation](https://github.com/user-attachments/assets/4f4d026e-5c09-41f9-be6a-142207c75e50) IMO we're not there yet: - open...

> I think one could argue that our mobile sidebars are a form of [modal dialog](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/). If so, then we should probably follow that pattern, which states: Tab and Shift...

> Should the tab key cycle back to the beginning when you get to the end of the sidebar? The ARIA patterns UX that you linked to says > If...

> Mostly it boils down to my strong preference to not muck with how the browser handles tab navigation because it quickly gets complicated. [...] I'm convinced. > Also to...

> What is the tool you use to generate this plot? `memory_profiler` is the tool. Run on command line like: ``` mprof run python my_script.py mprof plot ``` > What...

> I'd love to take up this issue and start working on a PR. Please let me know if there are any specific guidelines or expectations you'd like me to...

apologies for the delay, I haven't forgotten about this. Will look it over as soon as I'm able.