Ivaylo Draganov
Ivaylo Draganov
> @dragunoff I just though of something. Pay attention to the borders. This is how scroll widget looks in the PR > This is when `button-hover` and `button-highlighted-pressed` art switched....
> Should i open a mini PR for it? Yes, please go ahead.
> This seems weird. Why are we searching for non-existing images in the first place? Because we want to avoid declaring chrome images for every state of an UI element...
> Neither https://projectfluent.org/fluent/guide/ nor https://github.com/projectfluent/fluent/wiki/Good-Practices-for-Developers use any kind of redundant prefixes. I would recommend against adding those as well. > These are contrived documentation examples and I think that approach...
Update: rebased and addressed https://github.com/OpenRA/OpenRA/pull/20207#discussion_r962637302 and https://github.com/OpenRA/OpenRA/pull/20207#discussion_r962613625
Update: rebased and implemented attributes (see https://github.com/OpenRA/OpenRA/pull/20207#issuecomment-1239542263). I've expanded the translation linting to account for attributes and included a testcase commit that triggers all errors and warnings.
> I have split the attribute support and linting refactor into #20400 as I wanted to move forward. Hope you don't mind. Not at all :ok_hand: Thanks for picking this...
Update: rebased on #20400
I recently also went through the available sounds looking for a fitting sound for player name pinging. There are sounds that could work such as those proposed by @Smittytron. However...