Yilong Li

Results 21 comments of Yilong Li

233原来应该长那样 (:з」∠) 树叶辛苦,鞠躬

> need print `kubectl get po -A` when e2e test error exit. @shonge Could you PTAL at [`DumpAllNamespaceInfo`](https://github.com/kubernetes/kubernetes/blob/v1.16.0/test/e2e/framework/util.go#L1760), which is called in every `ginkgo.Describe` such as https://github.com/pingcap/tidb-operator/blob/146b2645a95d7d8e884b3620372aaed7d828d9cc/tests/e2e/tidbcluster/tidbcluster.go#L74 There's a `LogPodStates`...

# Current Progress - [x] `TidbCluster` - [ ] `TidbMonitor` - [ ] `TidbInitializer` - [ ] `Backup` - [ ] `Restore` - [ ] `BackupSchedule`

@AkioLove you could set `backup.spec.cleanPolicy` to `Retain` so that deleting Backup CR won't delete the underlying data.

this would be done when CRD generation issues are fixed

@wangzhanbing Thanks for your reply! But I still have some questions about the ordering. According to https://github.com/github/gh-ost/blob/8f361f6445c2fe1d830b053e315a70a69d60e73f/go/logic/migrator.go#L1267-L1293, the `applyEventsQueue` takes precedence over `copyRowsQueue`, so the update `(foo, 2)` could actually...

We can try to find out an automated way of testing, and run on Github Actions, which support Windows/Mac/Linux OS.

@cosmtrek Hi! Could you please take a look at this? Thanks!