David Allsopp

When’s the situation where you need to pass a specific fd _as that fd_, though? That was the point I was coming around to - if the file descriptor were...

The distinction I was trying to draw is that obviously there are times in C where you need to get at the C representation of the file descriptor - but...

> File descriptors are very much integers on *nix' they're just not on Windows! Because the hair-splitting is relevant here: _OCaml_ file descriptors are not integers on Windows - the...

Yes, indeed, a `private int` would be a good alternative - although where in Eio would one of these instances be? I've only had a cursory look at low_level.ml and...

Indeed - the additional packages have had an unintended consequence to what were _already_ imprecise/non-portable lock files. There’s work in flight to address that, but just to note that those...

Yes, indeed it has. Looking back at my diary, I think we hit an unfortunate series of mishaps that caused this to slip through the cracks, with apologies to @gaganchandan....

For this PR: - As a rule of thumb, tests which produce no output are not great (it's the testsuite version of the classic `let sort_list _ = []` formally-verified...

Ah, I confess I had my reverting brain switched on at the time (see https://github.com/ocaml/ocaml/pull/12108/files#diff-634a7188134ebafc936dd83ec93b4d275f5f997118b79ae975ee37050133581d)... I'll double-check why that was done before that way. The `+=` I agree looks dated.

Old duplicated definition removed and the `+=` switched to a `=` (so it's now an even more partial revert of #12108 while not regressing #13322 🤪)

@Octachron - OK to cherry-pick this to 5.2?