David Allsopp
David Allsopp
Original PR rebased
I've updated this PR to reflect the version of it that's included in #14247, which is simpler than my original proposal here (the diff can be seen with the [Compare...
Can I (lazily!) ask for the command I'd need to run to see? 😁
> I read through this PR, but not testing it (yet). I like very much the cleanup in the installation rules! I’ve taken a few notes, here and inlined. >...
Rebased - review responses to follow
Rebased on to #14245
I like the `--safe` idea - but I'd ruled out `Filename.quote` - as the quoting stands, it should be exactly quoting actual untrusted input the `"$1"`, etc. while leaving names...
Thanks, @kit-ty-kate! `--safe` added to those calls; in re-checking the equivalence of the interim shell scripts and `generate.ml`, I spotted that the `$CP` fallbacks weren't being correctly escaped on Windows...
Separately, this has been tortured on [precheck#1091](https://ci.inria.fr/ocaml/job/precheck/1091/) with a special check that builds the compiler and the trunk commit it sits on and compares the installation artefacts (i.e. checks that...
Updated torture version going through [precheck#1092](https://ci.inria.fr/ocaml/job/precheck/1092/). I've added a commit at the end of the series which adds guards in the Makefile-machinery to detect filenames which would cause problem, I've...