dr-robertk

Results 28 comments of dr-robertk

External ufl types.

Hi David, thanks for the quick answer. I was just wondering if in this particular case a quick fix could be implemented that updates the internal lists. It seems like...

[feature][ElementTypes] Added 4d element types

Thanks. I'm not sure if there are other places in UFL that need adjustment. This patch worked for me though.

[feature][ElementTypes] Added 4d element types

Thanks for taking care of it.

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication.

jenkins build this please

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication.

Any objections of this being merged?

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication.

jenkins build this please

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication.

@atgeirr: I removed the unused code.

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication.

jenkins build this please

faceNormal of UnstructuredGrid scaled with faceArea.

@atgeirr: I just wanted to point out that the two implementations, `CpGrid` and `UnstructuredGrid`, do something different here and it leads to trouble, as for example, experienced in opm-autodiff `GeoProps`....

faceNormal of UnstructuredGrid scaled with faceArea.

I hope we agree on the problem that the function `GridHelpers::faceNormal` should give the same answer for both grids, right? Then the question is, which of the grid implementations needs...