Dave Protasowski
Dave Protasowski
Looking at this today - I notice that changing the annotation of the revision will trigger a new replicaset to be created. This happens because we propagate the annotation to...
Closing in favour of https://github.com/knative/serving/pull/16186
I'm confused what's making HTTP2 requests? Knative healthchecks are HTTP/1
oh interesting - i didn't realize this was added. h2c upgrade is deprecated https://datatracker.ietf.org/doc/html/rfc9113#section-3.1 We should probably just always be doing HTTP/1 unless the user has specified h2c OR we...
You don't have an example app where this breaks?
Right now to support HTTP2 requires people to set the `containerPort` `name` to be `h2c`. ```yaml apiVersion: serving.knative.dev/v1 kind: Service metadata: name: grpc-ping namespace: default spec: template: spec: containers: -...
/lifecycle frozen seems like there are some golang changes in 1.24 (due out feb) that might make this simpler https://tip.golang.org/doc/go1.24#nethttppkgnethttp
From the go issue with 1.24 we now have > Go 1.24 includes support for unencrypted HTTP/2 client and server connections. Setting [Server.Protocols](https://pkg.go.dev/net/http#Server.Protocols) to a value which includes the UnencryptedHTTP2...
I'm good with whatever /assign @dsimansk