Dave Protasowski comments

Results 1317 comments of


                                            Dave Protasowski

fix panic when calling ToUnstructured on nil metav1.Time

/ok-to-test /assign @jpbetz

fix panic when calling ToUnstructured on nil metav1.Time

Looks like the owner file is out of date - @apelisse is the only approved On Wed, May 29, 2024 at 17:21 Kubernetes Prow Robot < ***@***.***> wrote: > [APPROVALNOTIFIER]...

GitHub Pull Request diff API responds with 406 — diff too large

Do the related actions need bumping ? eg. reviewdog/action-shellcheck etc?

GitHub Pull Request diff API responds with 406 — diff too large

Yeah it's still happening - do folks have any suggestions here? reviewdog: post failed for woke: fail to parse diff: GET https://api.github.com/repos/knative/serving/pulls/15066: 406 Sorry, the diff exceeded the maximum number...

Krsna step down

cc @knative/technical-oversight-committee

Krsna step down

@knative/steering-committee you need to approve the change

Krsna step down

Thanks for all your contribution Krsna

Krsna step down

can someone form steering `/approve` the PR

I'm worried people will forget this is turned off and not realize we're exposing ourselves

Further discussion: https://knative.slack.com/archives/CCSNR4FCH/p1604425778429100

I'm worried people will forget this is turned off and not realize we're exposing ourselves

Context: When we fetch dependencies we were getting 4xx errors because they didn't show up in the module mirror and checksum database (there's a bit of a delay). To avoid...