Dave Protasowski
Dave Protasowski
/lifecycle frozen
I'd like to echo @howardjohn's https://github.com/kubernetes/kubernetes/issues/95372#issuecomment-716179706 Testing with fake clients seems pretty fundamental to the k8s ecosystem and having them cooperate with informers would be a big win.
Is the plan to cut a release prior to closing this issue? It seems like the logging changes are in `main` ?
> So far I think this is intended behavior. This is a bug. Since the go.mod declares it's go version as go1.17 all the indirect dependencies are present. This list...
Even vendoring (ie. `go mod vendor`) includes the license - https://github.com/knative/func/tree/main/vendor/golang.org/x/sys
/lgtm /approve
I was sorta hoping for 1. Not needing to know the type (just a global option) 2. Not needing to pull in a protobuf dependency to ignore unexported proto fields
It would be good if we could control whether the library panics or returns an error - Knative has wrapped this library to handle that https://github.com/knative/pkg/blob/d0a82f9cbb8f2f92ce8f130c701f2da29bb33109/kmp/diff.go#L41
gengo - issue - https://github.com/kubernetes/gengo/issues/241
Workaround is to place an empty `go` file into the empty directory so that there is always code