Dave Protasowski

Results 1317 comments of Dave Protasowski

> If I change the default domain in config-domain to svc.cluster.local, all the ingress and ksvc reconcile and then I can create a new ksvc and everything including the ingress...

Hey @seongpyoHong it's a bit more complex because our queue proxy sidecar performs the probing in lieu of Kubernetes. This way we're able to poll more frequently than Kubernetes allows...

I'm going to add this to the 1.12 Milestone (October) - this would be great if someone could pick it up

@rhuss see @izabelacg's change - we disabled the clusterip on the private service. I believe for now it shouldn't be consuming any iptables entries. Can you confirm? With that change...

Note - we had to revert the cluster ip changes because it broke the autoscaler pod/cluster ip scraping

> Also there is this issue https://github.com/knative/serving/issues/13168 that discusses avoiding using the label. That's referring to the `app` label we're automatically adding to the revision pods/deployment. I think `role` is...

bump @a7i - you still interested in landing this PR?

> It will require a forced recreate. I see - then let's not worry about it then. /lgtm /approve