Dave Protasowski

Results 1317 comments of Dave Protasowski

/triage accepted Thanks for the deep breakdown everyone - I think what we really need is a clear signal to distinguish between the Pod shutting down and either container (queue-proxy/user-container)...

Hey @faxioman - the 1.6 release is today. I'll be taking a look at this for 1.7. > It would be very interesting to know how google cloud got around...

/area API > Such behaviour seems inconsistent with how k8s works, as the same image with the same ServiceAccount works fine as an ordinary Pod: I'm sort of in-different to...

Going to close this out as I haven't seen a compelling enough reason to change the behaviour

This surfaced again with a user using the following tooling: http://external-secrets.io/v0.5.6/ From slack: https://knative.slack.com/archives/C0186KU7STW/p1655389675950159 > I have an image that uses imagePullSecrets and I have an ExternalSecret that pulls it...

/lifecycle frozen /triage accepted I believe this will require changes to k8schain https://github.com/google/go-containerregistry/tree/main/pkg/authn/k8schain And we don't want to tight loop reconciliation if the secret isn't present - so we probably...

note - the visibility label doesn't go on the `spec.template.metadata.labels` but on the `metadata` of the top-level Knative Service or Route see: https://knative.dev/docs/serving/services/private-services Few things to take from this issue...

We've dropped the stackdriver exporters here: https://github.com/knative/pkg/issues/2173 This has dropped the queue proxy size (on my Mac) from 50MB to 30MB - so a diff of 20MB (~40%). There might...

So there are still gains to be made by dropping `k8s.io/api/core/v1 & `k8s.io/api/apps/v1` but it requires a lot of reshuffling of packages and types. Specifically the list is 1) https://github.com/knative/networking/pull/670...

/unassign @mattmoor /unassign @evankanderson