Dave Protasowski
Dave Protasowski
/ok-to-test
Change looks good - just see the linter warnings about extra whitespace
/lgtm /approve
You'll need to sign the CLA - see this comment https://github.com/knative/pkg/pull/3301#issuecomment-3649871422
/lgtm /approve Thanks for the change - let me know when you sort out the EasyCLA
easy cla isn't satisfied - unsure if you need to sign older commits? ``` git rebase --signoff HEAD~N ``` Generally though I thought it was tied to the email in...
I'm not really an EasyCLA expert so you'll want to open an issue here: https://github.com/linuxfoundation/easycla
Was thinking about this for https://github.com/knative/pkg/issues/3256. But honestly I don't think this should gate that change cc @evankanderson @Cali0707 for any input.
Also all the knobs can be manipulated with env vars https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/ eg. https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp#pkg-overview