Darren Loher
Darren Loher
Recommend submitting a PR to refactor this as suggested. To prevent a breaking change, please use deprecate on the existing list.
@robshakir ready for your re-review
@robshakir Ready for your next review
Looks straightforward to me. Please do open a PR, I will review. You can note that this is a breaking change to a v0 model.
Why not do a gnmi.Get and compare that to your planned config? [ygot.Diff](https://github.com/openconfig/ygot/blob/master/ygot/diff.go#L454-L490) provides functionality to compare two OC structs.
Regarding auto-rollback, there is a gnmi extension for commit (and confirm) which is for that purpose. https://github.com/openconfig/gnmi/blob/master/proto/gnmi_ext/gnmi_ext.proto#L97-L103
The proposed scope of this issue / requirement for Diff encompasses back end data stores which is a significant expansion of scope for gNMI and what is IMO the root...