public icon indicating copy to clipboard operation
public copied to clipboard

Add ingress policer to qos overview

Open dplore opened this issue 1 year ago • 4 comments

Adding documentation on how to use the /qos model to create an ingress policer

dplore avatar Sep 24 '24 20:09 dplore

No major YANG version changes in commit 978fb1a74ca84514b9edfe9f466f47fefe8e3ed4

OpenConfigBot avatar Sep 24 '24 20:09 OpenConfigBot

@robshakir ready for your re-review

dplore avatar Oct 02 '24 22:10 dplore

I don't think this is the appropriate way to describe a canonical ingress policer.

While the scheduling typically supports rate-limiting mechanisms, in many implementations, there are separate policer entities (often implemented in HW) that are independent of schedulers; i.e., those are two different mechanisms.

The fake queuing/ingress scheduling approach feels more like a workaround for implementations where true ingress policers are not available (or they never implement "real" ingress scheduling and can perform this config translation into policing in native yang/cli model). IMO it is fine if you want to describe that use case here, but stating that this is the (only) canonical way severely limits the range of covered scenarios and use cases.

In my view, the clearer approach is to introduce a new hierarchy to be used specifically to define standalone policers (e.g. /qos/policer-policies). This avoids any ambiguity w.r.t fake ingress queuing and allows for better extensibility.

LimeHat avatar Oct 03 '24 16:10 LimeHat

@robshakir Ready for your next review

dplore avatar Oct 08 '24 16:10 dplore