Daniel Piers comments

Results 5 comments of


                                            Daniel Piers

[SP] Fix animation event sounds not playing for NPC variants

Why? I can understand declining the pro-active memory safety fixes but this one and #1309 are clear and well documented bug fixes with open issues.

[SP] Fix animation event sounds not playing for NPC variants

Sorry - I didn't mean to PR spam. I am still learning to use/work with Claude Code and thought helping improve this codebase would be good practice, and it started...

[MP/SP] Increase MAX_ANIM_FILES from 16 to 64

Crash was reproduced, traced and fix tested with spawning >16 distinct NPCs. In practice, vanilla MP would need ~15 NPC slots max (+1 for player). 64 should be plenty even...

[MP/SP] Increase MAX_ANIM_FILES from 16 to 64

Updated to split the limits: - MAX_ANIM_FILES = 64 for animation skeletons (bgAllAnims[]) - MAX_ANIM_EVENT_FILES = 128 for event files (bgAllEvents[]) This addresses the concern about event files outnumbering anim...

[MP/SP] Increase MAX_ANIM_FILES from 16 to 64

> > Also added bounds checking in BG_AnimsetAlloc (bg_panimate.c:1713-1717) to protect bgAllAnims[] - returns NULL if limit is hit, which callers already handle. > > Why did you add this...