David Grote

Results 34 comments of David Grote

@ax3l I note that PR #33310 is making the same assumption since the documentation is referencing 'pywarp.picmi`. If that one works, then this one will work also.

If I can comment here, can this be done with templating instead of using the more obscure `std::is_same

There is the method `varlist()` that will return a list of the available class members for a Forthon object.

I don't think that this routine is needed. You can do ``` def setfaceobj(self,vv): return setattr(face, varname, vv) ``` This ends up calling the same routine `Forthon_setattro`.

Something like this is a good idea. Though, it looks like AMReX has a facility for setting the intial value. It looks like there are routines "MultiFab::set_do_initval" and "MultiFab::set_initval" that...

Thanks for this PR! Overall it looks good, but I do have a number of comments and questions.

The calls to `amrex::FillBoundary` in `PML_RZ.cpp` should be replaced with calls to `WarpXCommUtil::FillBoundary`. I can do this is a separate PR.

I merged again and it seems to have cleaned up the problem.

Thanks for your comments @EZoni ! For your second question, perhaps to provide full coverage, an RZ test could be added, but I don't think it is necessary. The code...

Thanks for the timings @RTSandberg. It's nice to know that timing was not affected much with the new code added when optimized. Did you see any indication about which part...