Dario Panici

Results 260 comments of Dario Panici
trafficstars

Would it be better to instead use an external package like https://github.com/freegs-plasma/FreeQDSK? Instead of us writing our own which invariably has less features

optional dependency, local import

https://github.com/PlasmaControl/DESC/blob/master/tests/test_objective_funs.py ctrl f "specials" and add umbilic objectices to that list, and then add a specific unit test to test those objetives below

I think the objective you added makes sense, it tries to align the alpha=0 field line with the umbilic curve. Something I am not sure of is, do your curves...

https://github.com/PlasmaControl/DESC/blob/master/CONTRIBUTING.rst#what-if-the-test_compute_everything-test-fails-or-there-is-a-conflict-in-master_compute_data_rpzpkl

- Use splines for both rootfind and integration - Keep exact method you have here for comparison

Biggest issue is we need to find everywhere that we may assume psi derivs are zero or constant (i.e. assuming the quadratic scaling)

#1015 could remove need for this issue

Use SOLOVEV analytic to test this