Dario Panici

Results 260 comments of Dario Panici
trafficstars

write what the actual test is checking (area diff), check if iota goes thru rational, also can make coiils and check against field tracing, one must be correct and one...

dont do pi/nfp otion for zeta, make issue to make compat function to change zeta=0 definition

We have added lots of stuff since the first time we noticed things were different here, can we check now again to see if the equilibrium solve without any hacky...

we'll wait for the benchmark to run again though as I wonder if it does make a difference. And for a 2nd reviewer as usual

TODO for me: make sure it caluculates the x's of EVERY coil (not just unique ones) so that it can properly avoid self intersection across the stellarator symmetry reflection plane

Just do this for "x" in the objective function

I would have preferred keeping this PR just coil-coil distance...

The test I added is failing at an unexpected place (when eq_fixed is False)... It is a JAX error complaining about int I think, but JAX encounters an error when...

> The test I added is failing at an unexpected place (when eq_fixed is False)... > > It is a JAX error complaining about int I think, but JAX encounters...