Dov Reshef
Dov Reshef
> Is there a way to add a test for this? Added by setting the client_name on the connection in the tests. Also rebased on master.
@Fogapod Any chance of reviewing this again?
I see. Thanks. @NoneGG Can this be merged? Reviewed?
Hi, all I've tried to take a stab at implementing this, since we need this as well. I looked at the [current implementation](https://github.com/tikv/rust-prometheus/blob/master/src/process_collector.rs) for the other prometheus crate. As part...
> @dovreshef would you be retrieving the information from the system in time or on an interval. I think the former is the Prometheus way. Sorry, I'm not sure I...
> Does that make sense @dovreshef? If so, would you like to prototype this? Sure. So the design is: * Have a new Collector trait that looks something like: ```rust...
> @dovreshef are you still interested in contributing the Collector pattern? :) Sorry I missed that message (and disappeared) but I planned to do this for work, and got pulled...
I have no problem with the spec. I simply did not understand that the output was indicating an error with the usage string. I thought it the result of some...
Looks like it will work for the process collector use case! Thanks.
> I think the reason I didn't originally bind this was the lifetime issue with data. I think we'll probably want to either make this unsafe or figure out a...