Asier Illarramendi

Results 74 comments of Asier Illarramendi

> Realizing that the squash merge will obliterate the history, unfortunately. If it's interesting to keep the history then someone with privileges could merge it instead?

Thanks for looking into this @bglw. I've double checked and there is definitely something going on here. For I moment you got me doubting regarding the scoring filter I'm applying,...

Check the video: - I show that the score filter (`.filter(({ score }) => score > minScore)`) AND the `pagefind.search` `filters` are removed from the code - Rebuild the index...

Just to clarify: - in the playground it works fine - but on my dialog I see the weird behavior, this happens in `1.2.0`, `1.3.0` and `1.4.0-alpha.1`

Hi! It's not a hassle, actually let me know if I can test anything to help you narrow the issue. I don't know if this useful, but this is the...

Meh, I suspected I wouldn't see much, in JS-land the search term doesn't change. I've tracked it until `backend.request_indexes` but then it switches to WASM and I don't know how...

It's not blocking the Bevy PR, but I suppose it's still an issue? I haven't tried it since I reported the issue. The Bevy PR got quite big and nobody...

I was thinking in local multiplayer with the impression that it might need something more complex. But I think this PR design is also OK for local multiplayer. These are...

@viridia, imo the approach of this PR is correct. In https://github.com/bevyengine/bevy/pull/15611#issuecomment-2511020639 I meant that **multi-focus is NOT something Bevy should solve**. I checked Super Mario Wonder which has local multiplayer:...

Thanks for the review @krunchington 🙏 I'll ask for a new one once I fix the issues and finish the CI part.