bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Upstream `naga_oil`

Open tychedelia opened this issue 1 year ago • 3 comments

naga_oil is a foundational crate for Bevy, but doesn't get enough love from community maintainers. We should include it in the monorepo so that it gets more care and attention. The crate was originally left out of the repo under the "useful to other external users" metric. However, since then, we have included other crates like bevy_color in the monorepo under and haven't seen uptake from external users that benefits naga_oil maintenence.

On the horizon, WESL promises to solve a lot of problems that we currently rely on naga_oil for. However, in the meantime, there are a number of important initiatives that would benefit from improvements made to naga_oil, including future initiatives like upstreaming bevy_hanabi and improvements to AsBindGroup that may require code generation strategies. Additionally, there are number of outstanding bugs ex. https://github.com/bevyengine/naga_oil/issues/54 that are more likely to get fixed if they live in our issue tracker.

Changes

  • History imported so we can have a record all the hard work @robtfm has done here.
  • The crate has been renamed to bevy_naga_oil so that its version can be reset to match the rest of the bevy crates.
  • Internal crates point to bevy_naga_oil.

tychedelia avatar Nov 23 '24 23:11 tychedelia

Realizing that the squash merge will obliterate the history, unfortunately.

tychedelia avatar Nov 24 '24 04:11 tychedelia

Thanks for all the copyediting @BenjaminBrienen! It's very much appreciated.

tychedelia avatar Nov 25 '24 03:11 tychedelia

Realizing that the squash merge will obliterate the history, unfortunately.

If it's interesting to keep the history then someone with privileges could merge it instead?

doup avatar Nov 25 '24 08:11 doup

Not planned, we're hoping to merge support for WESL and continue on that path.

tychedelia avatar Feb 25 '25 00:02 tychedelia