Doug Binks
Doug Binks
Some feedback: ## Mouse button naming The 'supported mouse buttons' naming is misleading, we would prefer 'mouse buttons tokens' so the sentence `release events for all pressed supported mouse buttons`...
> Where are initializations of the input modes located? It looks like the current values are all intialized to `GLFW_FALSE` by `glfwCreateWindow` when the window structure is allocated with `calloc`...
I concur. Do you want to change to using `GLFW_DISABLE_MOUSE_BUTTON_LIMIT`?
Thanks! I've not done a full review but have added some comments. I also note that we need to add `GLFW_DISABLE_MOUSE_BUTTON_LIMIT` to the comments above `glfwSetInputMode` in `glfw3.h`. I can...
I have squash merged your commits into my branch: https://github.com/glfw/glfw/compare/master...dougbinks:glfw:unlimited-mouse-buttons-merge This way I can make any required minor changes on this branch and merge it to GLFW once complete.
No problem - due to the release of GLFW 3.4 there was a merge which wasn't obvious, so I thought it best to handle this way. Hope that's OK!
After some discussions we decided that the term `GLFW_UNLIMITED_MOUSE_BUTTONS` was preferable and also followed the pattern of the rest of the GLFW API, so I've changed over to using that...
This has now been merged into main. Many thanks for your work on the PR, and your patience with my reviewing!
This does indeed look like #80. As per the linked issue GLFW doesn't call `glViewport` itself.
Altering enkiTS internals is non-trivial, and I wouldn't recommend doing so. I also don't quite understand what you want to do. The function `WaitforTask` is not doing any multi-threaded work,...