Noah Watkins

Results 315 comments of Noah Watkins

@imcdo Very supportive of adding type annotations and official formatting. Are you planning to merge this PR? > Use ruff for formatting and style checking. My understanding is that `ruff`...

@imcdo perhaps we could merge the `ruff` formatting in a PR (or a dedicated commit) separate from the type annotations? not having the reformatting noise would make reviewing the type...

@imcdo even something simple would be helpful: ``` pip install ruff==0.4.10 git checkout ian/types~ git checkout ian/types -- ruff.toml ruff format --config ruff.toml docs . git commit -a -m "format"...

> Hi @Lazin should we review `configuration.cc` for docs now or do you prefer to wait until it's out of draft? @Deflaimun i think you can ignore this completely. i'll...

> lgtm, approved in case we want to move forward with this instead of clang-format 18 we are going to move to clang-format-18

for the alignment changes where our clang-format settings currently has no preference and will keep the alignment unchanged, you could drip the changes into the tree over a series of...

@oleiman do you think we should add a static assert if it doesn't already exist that serde_fields _xor_ serde_read/write are used so we don't have to think about ambiguity if...

To add a little more context to this: Redpanda does not have sticky leadership in the same way that Kafka does, and will continuously attempt to maintain leadership balance across...

@travisdowns what do you think about closing this? v23.1 is now EOL and doesn't seem like this has been reported since (accept similar things being tracked in CI failures as...