Noah Watkins

Results 316 comments of Noah Watkins

No apparent problem in the logs. Could be a race condition. If good output from the compute_storage.py tool is not being produced (perhaps i'm misisng it) then we should add...

Hey @Jrc356, thanks for filing this. We're really excited about queues too. I'll let @deniscoady chime in and share any timelines that they are thinking about.

According to KIP-932, queues will depend on KIP-848 (see here https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255070434#KIP932:QueuesforKafka-Sharegroupmembership) assuming that that information is current, which I believe it is.

Forced pushed to add missing interface used in a test. https://github.com/redpanda-data/redpanda/compare/4228989d1281a6bf506c2ee76b38b245372b822b..8007461bdc2fb6a9649ac1ca9c42c81c0187e897

~I will probably switch this over to use abseil inlinedvector after examining it i think we can achieve a similar uninitialized allocation optimization.~

@travisdowns @StephanDollberg @rockwotj in the interest of avoiding the UB concern entirely (but like travis mentioned, perhaps its UB that we are ok with), i added a new commit that...

> As a side note, it looks like `std::string` now (as of C++23) has the ability to be created but uninitialized with [resize_and_overwrite](https://en.cppreference.com/w/cpp/string/basic_string/resize_and_overwrite). It's been around in libc++ for a...

>Instruction and alloc count diffs from other microbenches: that seems unsurprising with abseil's inlined vector. what's the threshold for concern?

> Overall the code LGTM, just one thing that the new struct is 8 bytes bigger and IDK if that's OK. yeh, also noticed this. i don't think it matters,...

thanks for the review @rockwotj. i have a merge conflict, and a few things to cleanup. should be able to get this posted again next week.