Logan Hunt

Results 84 comments of Logan Hunt

I did not know that services that where injected got added to the `di` object. The issue now is that `c` will be type Any, and I will need to...

Thank you for the kind words! This is similar to #15, but different in that it suggests Refurb should support nested config files. This wasn't a use case I had...

I think that the config path idea is worth exploring more. I agree that the name of the file should be pretty standardized, since the path is what is actually...

I agree that certain default values are not very common, and as such, aren't very well known/remembered. In that regard, explicitly passing a default is preferable. This check is somewhat...

Ok, after some thought I agree that this check should be disabled by default. I will go ahead and disable it sometime before the next release.

Hi @cclauss , thank you for bring this up! I have always just used `pip`, but I know `pipx` and `poetry` are some of the more popular alternatives. I think...

Thank you for mentioning this. From the user perspective it might be a bit annoying to fix a certain line, only to have it complain about something else when you...

You're right, I did not pick up on that. Here is a MVP that shows it better (IMO): ```python from pathlib import Path from contextlib import suppress, nullcontext with suppress(FileNotFoundError):...

Also, this made me realize that there is a different bug in the FURB107 check, in that `suppress()` with no args will not suppress anything, and I thought it actually...

I have fixed the bare exception `suppress()`, PR coming soon. I agree that bare exceptions shouldn't be used, but to make it have the same behavior you have to do...