Darrel O'Pry

Results 377 comments of Darrel O'Pry

@lullis I would mock `id_token.send_backchannel_logout_request()` to throw an exception along the lines of ``` from unittest.mock import patch, Mock with patch('your_module.your_function') as mock_func: mock_func.side_effect = ValueError("Something went wrong!") ``` before...

sorry I've been a little busy with life the last month or so and the move from jazzband took up a fair bit of my available OSS time. I'm going...

I hear you. With the backchannel logout, I'm trying to figure out a good end to end test. Normally we use the tests/app/[idp,rp] to do end to end testing of...

got the tests/app/[idp,rp] setup for backchannel logout in a local commit. see: https://github.com/dopry/django-oauth-toolkit/tree/1545_backchannel_logout generally it's looking good. I am seeing multiple backchannel logout request when I logout after a few...

@lullis I've been thinking about this a bit. We need to be more selective about what clients we notify. We definitely shouldn't send a logout request for every id token....

@lullis could you please rebase this PR?

@lullis at a glance this looks pretty good and follows my understanding of prompt=create. I'll try to give it a proper review next week. ping me if you don't hear...

yep and it's still on my radar. As soon as we get the repo transferred out of jazzband i'm going to get codecov fixed merge the other PRs in our...

@lullis could you resolve the conflicts and rebase this one when you get a chance?

We need to get codecov passing before we can merge this.