Darrel O'Pry

Results 377 comments of Darrel O'Pry

@zerolab I'll work on a fix to get_specific_page. I feel like, in a future release, it may be wise to have a separate graphql query for getPagePreview(token: String!). There are...

@richardARPANET can you describe how this is setup with MS OAuth for me to better understand the setup for testing. I'd like to do a live test. We'll need a...

@lullis 1. for now the back channel can live in the logout request, we can move it later. Maybe start with a fire and forget approach to minimize blocking. Rather...

1. I forget the world hasn't moved to async/await across the board. It's fine to do the work in the signal handler. 2. The spec says `A Logout Token MUST...

@lullis it looks like the next step is expanding test coverage right now the patch is just shy of 70%, our target is 100% coverage on patches going forward. At...

It seems something has changed with the jazzband Codecov account and our codecov uploads are getting rate limited. I don't have the necessary permissions to add a the codecov repository...

@lullis I hear you. Right now I'm in a bit of a holding pattern waiting on @jezdez to transfer the project out of jazzband so we can fix our codecov...

No @jezdez still hasn't transferred the repo.

@lullis org is transferred. Can you rebase this PR on the latest master?

@lullis it looks like we still have some pretty big gaps in test code coverage for the backchannel logout functionality. Will you have time to work on that? Is there...